Add check for acceptable routing strategies #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
Jeffwan
reviewed
Nov 7, 2024
| @@ -46,6 +47,7 @@ import ( | |||
| var ( | |||
| defaultRPM = 100 | |||
| defaultTPMMultiplier = 1000 | |||
| routingStrategies = []string{"random", "least-request", "throughput"} | |||
There was a problem hiding this comment.
is there source of truth or single constant we can use? I remember somewhere else have the definition
|
The change looks good to me, just minor suggestion on the single constants |
Jeffwan
approved these changes
Nov 7, 2024
|
Varun mentioned there's no constants to use at this moment. so we can merge it now and improve it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate routing strategy in inference request is correct: #333 #334