Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial lora benchmark result #321

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Oct 25, 2024

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan force-pushed the jiaxin/lora-benchmark-beneifts branch 2 times, most recently from 98f1bf8 to 79fa137 Compare October 27, 2024 04:08
@Jeffwan Jeffwan force-pushed the jiaxin/lora-benchmark-beneifts branch 2 times, most recently from 377a233 to fd59edb Compare October 28, 2024 21:59
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Oct 28, 2024

@happyandslow I will discard the plot PR

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Oct 28, 2024

I will merge the code now.

@Jeffwan Jeffwan merged commit 6fda762 into main Oct 28, 2024
18 checks passed
@Jeffwan Jeffwan deleted the jiaxin/lora-benchmark-beneifts branch October 28, 2024 22:14
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
Add lora benchmark guidance and scripts

Update scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant