Use vllm metrics for routing #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
approved these changes
Oct 5, 2024
| return metricValue, nil | ||
| } | ||
|
|
||
| func parseMetricFromBody(body []byte, metricName string) (float64, error) { |
There was a problem hiding this comment.
autoscaler has similar features. Let's refactor this part later and make sure cache and autoscaler fetcher can use same library
There was a problem hiding this comment.
Agree. Let me discuss with him
|
PR looks good to me. |
Updated the MR with cache to pull metrics once for each pod. |
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Cache bug fix in update pod and model mapping (#259) * test * Use vllm metrics for routing * nit reverts * update log level * refactor cache to fetch metrics once * remove port from random routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.