Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Use klog as the logr implementation #264

Merged
merged 4 commits into from
Oct 3, 2024
Merged

[Misc] Use klog as the logr implementation #264

merged 4 commits into from
Oct 3, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Oct 2, 2024 •
edited
Loading

Pull Request Description

Log examples after this change. Append --v 4 to display debug level messages

I1002 00:43:56.550742   90335 main.go:169] "msg"="starting cache" "logger"="setup"
I1002 00:43:56.550905   90335 main.go:180] "msg"="using configuration from '/Users/bytedance/.kube/config'" "logger"="setup"
I1002 00:43:56.661395   90335 modelrouter_controller.go:51] "Starting modelrouter controller"
I1002 00:43:56.665327   90335 main.go:208] "msg"="starting manager" "logger"="setup"
I1002 00:43:56.665830   90335 server.go:185] "msg"="Starting metrics server" "logger"="controller-runtime.metrics"
I1002 00:43:56.666380   90335 server.go:224] "msg"="Serving metrics server" "bindAddress"=":8080" "logger"="controller-runtime.metrics" "secure"=false
I1002 00:43:56.667443   90335 server.go:50] "msg"="starting server" "addr"={"IP":"::","Port":8081,"Zone":""} "kind"="health probe"
E1002 00:43:56.687097   90335 modelrouter_controller.go:164] httproutes.gateway.networking.k8s.io "llama2-70b-router" already exists
I1002 00:43:56.769484   90335 controller.go:178] "msg"="Starting EventSource" "controller"="rayclusterreplicaset" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterReplicaSet" "source"="kind source: *v1alpha1.RayClusterReplicaSet"
I1002 00:43:56.769495   90335 controller.go:178] "msg"="Starting EventSource" "controller"="podautoscaler" "controllerGroup"="autoscaling.aibrix.ai" "controllerKind"="PodAutoscaler" "source"="kind source: *v1alpha1.PodAutoscaler"
I1002 00:43:56.769500   90335 controller.go:178] "msg"="Starting EventSource" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet" "source"="kind source: *v1alpha1.RayClusterFleet"
I1002 00:43:56.769580   90335 controller.go:178] "msg"="Starting EventSource" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter" "source"="kind source: *v1alpha1.ModelAdapter"
I1002 00:43:56.769625   90335 controller.go:178] "msg"="Starting EventSource" "controller"="rayclusterreplicaset" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterReplicaSet" "source"="kind source: *v1.RayCluster"
I1002 00:43:56.770770   90335 controller.go:178] "msg"="Starting EventSource" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter" "source"="kind source: *v1.Service"
I1002 00:43:56.770865   90335 controller.go:178] "msg"="Starting EventSource" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter" "source"="kind source: *v1.EndpointSlice"
I1002 00:43:56.770900   90335 controller.go:178] "msg"="Starting EventSource" "controller"="podautoscaler" "controllerGroup"="autoscaling.aibrix.ai" "controllerKind"="PodAutoscaler" "source"="kind source: *v2.HorizontalPodAutoscaler"
I1002 00:43:56.770929   90335 controller.go:178] "msg"="Starting EventSource" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter" "source"="kind source: *v1.Pod"
I1002 00:43:56.771120   90335 controller.go:186] "msg"="Starting Controller" "controller"="rayclusterreplicaset" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterReplicaSet"
I1002 00:43:56.771221   90335 controller.go:186] "msg"="Starting Controller" "controller"="podautoscaler" "controllerGroup"="autoscaling.aibrix.ai" "controllerKind"="PodAutoscaler"
I1002 00:43:56.771283   90335 controller.go:178] "msg"="Starting EventSource" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet" "source"="kind source: *v1alpha1.RayClusterReplicaSet"
I1002 00:43:56.771320   90335 controller.go:178] "msg"="Starting EventSource" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet" "source"="kind source: *v1.RayCluster"
I1002 00:43:56.771350   90335 controller.go:186] "msg"="Starting Controller" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet"
I1002 00:43:56.772347   90335 controller.go:186] "msg"="Starting Controller" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter"
I1002 00:43:56.884773   90335 controller.go:220] "msg"="Starting workers" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter" "worker count"=1
I1002 00:43:56.885469   90335 controller.go:220] "msg"="Starting workers" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet" "worker count"=1
I1002 00:43:56.885615   90335 controller.go:220] "msg"="Starting workers" "controller"="rayclusterreplicaset" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterReplicaSet" "worker count"=1
I1002 00:43:56.902085   90335 controller.go:220] "msg"="Starting workers" "controller"="podautoscaler" "controllerGroup"="autoscaling.aibrix.ai" "controllerKind"="PodAutoscaler" "worker count"=1
^CI1002 00:44:53.935701   90335 internal.go:516] "msg"="Stopping and waiting for non leader election runnables"
I1002 00:44:53.936350   90335 internal.go:520] "msg"="Stopping and waiting for leader election runnables"
I1002 00:44:53.936674   90335 controller.go:240] "msg"="Shutdown signal received, waiting for all workers to finish" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter"
I1002 00:44:53.936866   90335 controller.go:240] "msg"="Shutdown signal received, waiting for all workers to finish" "controller"="podautoscaler" "controllerGroup"="autoscaling.aibrix.ai" "controllerKind"="PodAutoscaler"
I1002 00:44:53.937015   90335 controller.go:240] "msg"="Shutdown signal received, waiting for all workers to finish" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet"
I1002 00:44:53.936827   90335 controller.go:240] "msg"="Shutdown signal received, waiting for all workers to finish" "controller"="rayclusterreplicaset" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterReplicaSet"
I1002 00:44:53.938159   90335 controller.go:242] "msg"="All workers finished" "controller"="rayclusterfleet" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterFleet"
I1002 00:44:53.938461   90335 controller.go:242] "msg"="All workers finished" "controller"="model-adapter-controller" "controllerGroup"="model.aibrix.ai" "controllerKind"="ModelAdapter"
I1002 00:44:53.938327   90335 controller.go:242] "msg"="All workers finished" "controller"="podautoscaler" "controllerGroup"="autoscaling.aibrix.ai" "controllerKind"="PodAutoscaler"
I1002 00:44:53.938585   90335 controller.go:242] "msg"="All workers finished" "controller"="rayclusterreplicaset" "controllerGroup"="orchestration.aibrix.ai" "controllerKind"="RayClusterReplicaSet"
I1002 00:44:53.938902   90335 internal.go:528] "msg"="Stopping and waiting for caches"

Related Issues

Resolves: Address #69

Important: Before submitting, please complete the description above and review the checklist below.

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@varungup90 varungup90 force-pushed the main branch 3 times, most recently from 506a803 to d72a9c0 Compare October 2, 2024 23:10
@varungup90
Copy link
Collaborator

I think it needs to be rebased with main branch.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Oct 3, 2024 •
edited
Loading

Seems this change doesn't change anything in https://github.com/aibrix/aibrix/pull/271/files

--

Update: I rebase the main and push the new change, It should be ok now

@Jeffwan Jeffwan force-pushed the jiaxin/logr-configuration branch from 3901f09 to 9abc094 Compare October 3, 2024 17:37
@Jeffwan Jeffwan merged commit 4047e3d into main Oct 3, 2024
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/logr-configuration branch October 3, 2024 17:53
@Jeffwan Jeffwan mentioned this pull request Oct 5, 2024
Closed
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
@Jeffwan
[Misc] Use klog as the logr implementation (#264)
8eab8d1 
* Consistently use klog as the logger in codes

* Resolve the logr and klog version incompatibility

* Ignore the deprecated lint check for klogr.New()

* Add object meta for further debugging

This is an improvement to reproduce #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungup90 varungup90 varungup90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeffwan @varungup90