Optimize project layouts by moving controllers to pkg folder #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
force-pushed
the
jiaixn/optimize-project-layout
branch
from
29eeec3 to
730898b
Compare
Jeffwan
commented
Jul 12, 2024
| @@ -118,15 +118,15 @@ func main() { | |||
| // LeaderElectionReleaseOnCancel: true, | |||
| }) | |||
| if err != nil { | |||
| setupLog.Error(err, "unable to start manager") | |||
| setupLog.Error(err, "unable to create manager") | |||
There was a problem hiding this comment.
@varungup90 address the PR review from last round
There was a problem hiding this comment.
I need this change (folder structure) for the coming ones. I will merge it now. Feel free to leave comments if anything doesn't look good to you. I will address them later
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Move internal/controllers under pkg/ * Update controller path to pkg in utils tools * Address feedback from last PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #16 #19
We should exactly follow kubebuilder's layout. Moving
internal/controllersunderpkg