Scaffolding aibrix project using kubebuilder #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“kubebuilder init --domain "aibrix.ai" --project-name aibrix”
`kubebuilder create api --group autoscaling --version v1alpha1 --kind PodAutoscaler`
varungup90
reviewed
Jul 12, 2024
| Client: mgr.GetClient(), | ||
| Scheme: mgr.GetScheme(), | ||
| }).SetupWithManager(mgr); err != nil { | ||
| setupLog.Error(err, "unable to create controller", "controller", "PodAutoscaler") |
There was a problem hiding this comment.
unable to create PodAutoscaler controller.
There was a problem hiding this comment.
nice catch. I have a follow up PR on the structure adjustment. I will update the name there.
varungup90
reviewed
Jul 12, 2024
| // LeaderElectionReleaseOnCancel: true, | ||
| }) | ||
| if err != nil { | ||
| setupLog.Error(err, "unable to start manager") |
There was a problem hiding this comment.
unable to create manager
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Remove placeholder folders to avoid failures in skeleton generation * Init aibrix go module * Scaffolding aibrix project using kubebuilder “kubebuilder init --domain "aibrix.ai" --project-name aibrix” * Enable Multi-Group API feature * Add PodAutoscaler api and controllers `kubebuilder create api --group autoscaling --version v1alpha1 --kind PodAutoscaler` * Generate podautoscaler manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #16
This PR mainly focus on the skeleton generation
Versions