Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using sphinx to generate html pages for our project static site #153

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

xinchen384
Copy link
Contributor

Pull Request Description

Set up basic layout of AIbrix's static site with html pages.

Related Issues

Resolves: #[Insert issue number(s)]

  1. Main page cover item lists. Both left and right side menu is synced with documentation section.
  2. Adding picture works and tree structure is also available with directories.
  3. Test generating html pages on both Dev node and local laptop with web browser.

Here is a screen shot.
image

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 10, 2024

we do not want that deep hierarchy, can we move all files under docs directly? i will help refactor rest folders later.

docs/
├── Makefile
├── README.md
├── make.bat
└── source

Make sure that your python conda environment is setup correctly. The following installs sphinx package and necessary templates.

```bash
python -m pip install sphinx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installation should be consistent? why not directly use pip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack


```bash
python -m pip install sphinx
pip install sphinx-book-theme
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have more dependencies, let's create a requirement.txt to track the dependencies. It would be great to pin the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

# https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information

project = 'AIBrix'
copyright = '2024, ByteDance InfraLab-Compute'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> AIBrix Team


project = 'AIBrix'
copyright = '2024, ByteDance InfraLab-Compute'
author = 'ByteDance InfraLab-Compute'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIBrix Team

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@xinchen384
Copy link
Contributor Author

we do not want that deep hierarchy, can we move all files under docs directly? i will help refactor rest folders later.

docs/
├── Makefile
├── README.md
├── make.bat
└── source

I think it is confusing If the source folder is mixed with "tutorial" folder and others. Yes, I can move it if there is refactor for the existed folders.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 10, 2024

@xinchen384 Yeah, mixing tutorial etc and source together is an intermediate state. we will refactor it in coming days.

@xinchen384
Copy link
Contributor Author

I have pinned the pip version. Since this is just for webpage, the 2 dependencies are all we need. Everything else is updated accordingly. @Jeffwan

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 10, 2024

The change looks good to me! Great to see we have a site now!

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 10, 2024

Feel free to merge it once the CI pass

@xinchen384 xinchen384 merged commit 705f6b6 into main Sep 10, 2024
3 checks passed
@xinchen384 xinchen384 deleted the xin/webpage branch September 10, 2024 21:14
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* using sphinx build html pages

* update readme

* reorg doc path

* update command with new parent dir

* update author

---------

Co-authored-by: xin.chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants