Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make generate #132

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Update make generate #132

merged 10 commits into from
Sep 6, 2024

Conversation

varungup90
Copy link
Collaborator

@varungup90 varungup90 commented Sep 5, 2024

Address #131 #130

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 6, 2024

Does doc.go deep-gen tag help? without removing the generate

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me

@Jeffwan Jeffwan merged commit 5a7e819 into main Sep 6, 2024
3 checks passed
@Jeffwan Jeffwan deleted the update-make-generate branch September 6, 2024 20:24
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* update make generate and add clientset for orchestration/v1alpha1

* add make verify

* nit makefile changes

* add verify in ci

* add license

* nit

* nit

* remove make verify for now

* restore make generate, remove doc.go and add make verify-codegen in CI

* add generate in other make commands

---------

Co-authored-by: varungupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants