Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway installation #122

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Add gateway installation #122

merged 2 commits into from
Sep 5, 2024

Conversation

varungup90
Copy link
Collaborator

@varungup90 varungup90 commented Sep 4, 2024

Address #114

## helm creates objects without aibrix prefix, hence deploying gateway components outside of kustomization
helm install eg oci://docker.io/envoyproxy/gateway-helm --version v1.1.0 -n aibrix-system --create-namespace
$(KUBECTL) wait --timeout=5m -n aibrix-system deployment/envoy-gateway --for=condition=Available
$(KUBECTL) apply -f config/gateway/gateway.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em. Now we install kustomize package (gateway-plugin) -> dependencies -> gateway.yaml. The sequence is not that clean. Not sure any problem moving gateway.yaml under kustomize? We probably can do 3rd party dependencies (gateway) first, and then aibrix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make install does two things-> envoy gateway (using helm command) + gateway dependencies such as envoy patch policy & envoy extension policy (using gateway.yaml)

make deploy install redis and gateway plugins (ext proc).

Copy link
Collaborator

@Jeffwan Jeffwan Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

development flow might be different from one-click prod installation flow. If this is the flow. then we do not have gateway.yaml and helm package included.
https://github.com/aibrix/aibrix/blob/0d64aca2c437b74fc64a4f0df9b6e81d7399ed95/README.md?plain=1#L16-L25

@Jeffwan Jeffwan merged commit 9f25dff into main Sep 5, 2024
2 checks passed
@Jeffwan Jeffwan deleted the one-click-gateway branch September 5, 2024 01:10
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add gateway installation

* address comments

---------

Co-authored-by: varungupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants