Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Support container image build and push in CI #120

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 4, 2024

Pull Request Description

  1. Add docker-build in CI and make sure container image build won't break due to the new changes
  2. Push to dockerhub after PR merges. Create separate nightly tag for every image.

Related Issues

Resolves: #30 #93

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan changed the title Support container image build and push in CI [CI] Support container image build and push in CI Sep 4, 2024
@Jeffwan Jeffwan force-pushed the jiaxin/docker-build branch from 9e32fd1 to e3286db Compare September 4, 2024 22:54
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 5, 2024

@kr11 I will merge this PR to test push images. If you have any comments, feel free to leave them here and I will address in follow up PRs

@Jeffwan Jeffwan merged commit 142e85e into main Sep 5, 2024
3 checks passed
@Jeffwan Jeffwan deleted the jiaxin/docker-build branch September 5, 2024 13:26
@kr11
Copy link
Collaborator

kr11 commented Sep 5, 2024

@kr11 I will merge this PR to test push images. If you have any comments, feel free to leave them here and I will address in follow up PRs

Sorry for the late response. I just review it, this PR looks good to me.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 5, 2024

@kr11 no worries!

gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Support container image build and push in CI

* Remove the pull request check for image push

* Optimize the test parallelism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Setup the docker hub integration
3 participants