Autoscaling Workflow Enhancement - Part 4: Integrating MetricClient into Autoscaling Workflow #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr11
force-pushed
the
kangrong/features/autoscaling_workflow_part4
branch
from
b487853 to
901bc86
Compare
kr11
changed the title
kr11
force-pushed
the
kangrong/features/autoscaling_workflow_part4
branch
from
901bc86 to
3a96e20
Compare
Jeffwan
reviewed
Sep 4, 2024
- Minor refactoring of Window and AutoScaler interfaces - Adjust Reconcile workflow - Add tests.
kr11
force-pushed
the
kangrong/features/autoscaling_workflow_part4
branch
from
e28450b to
ac50366
Compare
|
I have fixed the conflict and rebased on up-to-date main branch. @Jeffwan |
Jeffwan
approved these changes
Sep 6, 2024
|
the PR looks good to me |
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
…nto Autoscaling Workflow (#116) * enrich mocked vllm app * update README * Integrate metricsClient into KPA, Debug mode successful. - Minor refactoring of Window and AutoScaler interfaces - Adjust Reconcile workflow - Add tests. * add readme * fix make lint-all * fix readme, add more description * add missing yaml * optimize role name * fix readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Compared to Part 3 (#101), this update introduces the metricsClient phase and completes the entire workflow, except the periodic resync AutoScaler invoking.
Adding Prometheus Metrics Interface for Mocked Llama App:
mocked llama-7bapplication located indocs/development/app.mocked llama-7bnow first checks the latest number of replicas before returning metrics calculated asfix_total/replicas, thereby inversely relating metrics to the number of replicas. This change ensures that the scaling metrics dynamically adjust based on the current load distribution across replicas. See related issue [Enhance Mocked vLLM App with Dynamic Metrics for Autoscaling Efficiency #117] for more details.Integration of MetricClient into the Autoscaling Process:
metricsClientinto the autoscaling workflow, instantiated during the creation of the Reconciler.Add tests and README.
Related Issues
Resolves: #117
TODO: #119
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.