fix: add base to virtual html #16442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
XiSenao
added
the
p3-minor-bug
sapphi-red
previously approved these changes
Apr 17, 2024
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, histoire, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
patak-dev
reviewed
Apr 18, 2024
| @@ -200,7 +200,7 @@ const devHtmlHook: IndexHtmlTransformHook = async ( | |||
| // and ids are properly handled | |||
| const validPath = `${htmlPath}${trailingSlash ? 'index.html' : ''}` | |||
| proxyModulePath = `\0${validPath}` | |||
| proxyModuleUrl = wrapId(proxyModulePath) | |||
| proxyModuleUrl = joinUrlSegments(base, wrapId(proxyModulePath)) | |||
There was a problem hiding this comment.
Maybe we could move the joinUrlSegments out of these two branches so it is more clear that this always need to be added.
proxyModuleUrl = joinUrlSegments(base, proxyModuleUrl)
patak-dev
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
baseoption and virtual modules #15873