Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--use_prepared_statements=0 in ci.yaml is broken #115

Closed
mjskier opened this issue May 25, 2021 · 1 comment
Closed

--use_prepared_statements=0 in ci.yaml is broken #115

mjskier opened this issue May 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@mjskier
Copy link

mjskier commented May 25, 2021

In init() in driver_test.go, the following 2 lines are commented out

testing.Init()
flag.Parse()

which means any arguments passed to go test in ci.yaml is not taken into consideration.
If you uncomment these 2 lines, you will find that tests with the --use_prepared_statements=0 option fail with the following error in TestBasicArgsWithNil()

driver_test.go:353: Error: [42601] Syntax error at or near ","
@sitingren sitingren added the bug Something isn't working label May 26, 2021
@sitingren
Copy link
Member

@mjskier Thanks for your report! I merged a quick fix for this issue.

mjskier added a commit to bmyers-csu/vertica-sql-go that referenced this issue May 27, 2021
bmyers-csu pushed a commit to bmyers-csu/vertica-sql-go that referenced this issue May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants