-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix locale negotiation, fix #18676 #19552
Conversation
acceptPreferredLocale === defaultLocale && | ||
languages[0] !== defaultLocale | ||
) { | ||
// TODO: Bubble this up since we're serving default locale instead of preferred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This piece if analytics is fairly important but not sure how this is done in next.js?
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 9.4s | 9.5s | |
nodeModulesSize | 85 MB | 85.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.135 | 2.186 | |
/ avg req/sec | 1170.75 | 1143.46 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.198 | 1.237 | |
/error-in-render avg req/sec | 2087.56 | 2020.31 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 11.6s | 11.3s | -278ms |
nodeModulesSize | 85 MB | 85.5 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_error.js | 996 kB | 996 kB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 996 kB | 996 kB | ✓ |
link.js | 1.05 MB | 1.05 MB | ✓ |
routerDirect.js | 1.04 MB | 1.04 MB | ✓ |
withRouter.js | 1.04 MB | 1.04 MB | ✓ |
Overall change | 5.13 MB | 5.13 MB | ✓ |
Failing test suitesCommit: 25d7bab test/integration/i18n-support-base-path/test/index.test.js
Expand output● i18n Support basePath › dev mode › should have correct values for non-prefixed path
● i18n Support basePath › dev mode › should not have hydration mis-match from hash
● i18n Support basePath › dev mode › should resolve auto-export dynamic route correctly
● i18n Support basePath › dev mode › should navigate to auto-export dynamic page
● i18n Support basePath › dev mode › should apply rewrites correctly
● i18n Support basePath › dev mode › should navigate with locale prop correctly
● i18n Support basePath › dev mode › should navigate with locale prop correctly GSP
● i18n Support basePath › dev mode › should navigate with locale false correctly
● i18n Support basePath › dev mode › should navigate with locale false correctly GSP
● i18n Support basePath › dev mode › should update asPath on the client correctly
● i18n Support basePath › dev mode › should use correct default locale for locale domains
● i18n Support basePath › dev mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › dev mode › should handle locales with domain
● i18n Support basePath › dev mode › should provide correctly defaultLocale for locale domain
● i18n Support basePath › dev mode › should generate AMP pages with all locales
● i18n Support basePath › dev mode › should work with AMP first page with all locales
● i18n Support basePath › dev mode › should generate fallbacks with all locales
● i18n Support basePath › dev mode › should generate auto-export page with all locales
● i18n Support basePath › dev mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › dev mode › should 404 for GSP pages that returned notFound
● i18n Support basePath › dev mode › should transition on client properly for page that starts with locale
● i18n Support basePath › dev mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › dev mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › dev mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › dev mode › should use default locale for / without accept-language
● i18n Support basePath › dev mode › should load getStaticProps page correctly SSR
● i18n Support basePath › dev mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › dev mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › dev mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › dev mode › should navigate client side for default locale with no prefix
● i18n Support basePath › dev mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › dev mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › dev mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › dev mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › dev mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › dev mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › dev mode › should navigate to another page and back correctly with locale
● i18n Support basePath › dev mode › should navigate to getStaticProps page and back correctly with locale
● i18n Support basePath › production mode › should have correct values for non-prefixed path
● i18n Support basePath › production mode › should not have hydration mis-match from hash
● i18n Support basePath › production mode › should resolve auto-export dynamic route correctly
● i18n Support basePath › production mode › should navigate to auto-export dynamic page
● i18n Support basePath › production mode › should apply rewrites correctly
● i18n Support basePath › production mode › should navigate with locale prop correctly
● i18n Support basePath › production mode › should navigate with locale prop correctly GSP
● i18n Support basePath › production mode › should navigate with locale false correctly
● i18n Support basePath › production mode › should navigate with locale false correctly GSP
● i18n Support basePath › production mode › should update asPath on the client correctly
● i18n Support basePath › production mode › should handle fallback correctly after generating
● i18n Support basePath › production mode › should use correct default locale for locale domains
● i18n Support basePath › production mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › production mode › should handle locales with domain
● i18n Support basePath › production mode › should provide correctly defaultLocale for locale domain
● i18n Support basePath › production mode › should generate AMP pages with all locales
● i18n Support basePath › production mode › should work with AMP first page with all locales
● i18n Support basePath › production mode › should generate fallbacks with all locales
● i18n Support basePath › production mode › should generate auto-export page with all locales
● i18n Support basePath › production mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › production mode › should not output GSP pages that returned notFound
● i18n Support basePath › production mode › should 404 for GSP pages that returned notFound
● i18n Support basePath › production mode › should transition on client properly for page that starts with locale
● i18n Support basePath › production mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › production mode › should use default locale for / without accept-language
● i18n Support basePath › production mode › should load getStaticProps page correctly SSR
● i18n Support basePath › production mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › production mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should navigate client side for default locale with no prefix
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › production mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › production mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › production mode › should navigate to another page and back correctly with locale
● i18n Support basePath › production mode › should navigate to getStaticProps page and back correctly with locale
● i18n Support basePath › serverless mode › should have correct props for blocking notFound
● i18n Support basePath › serverless mode › should have correct values for non-prefixed path
● i18n Support basePath › serverless mode › should not have hydration mis-match from hash
● i18n Support basePath › serverless mode › should resolve auto-export dynamic route correctly
● i18n Support basePath › serverless mode › should navigate to auto-export dynamic page
● i18n Support basePath › serverless mode › should apply rewrites correctly
● i18n Support basePath › serverless mode › should navigate with locale prop correctly
● i18n Support basePath › serverless mode › should navigate with locale prop correctly GSP
● i18n Support basePath › serverless mode › should navigate with locale false correctly
● i18n Support basePath › serverless mode › should navigate with locale false correctly GSP
● i18n Support basePath › serverless mode › should update asPath on the client correctly
● i18n Support basePath › serverless mode › should handle fallback correctly after generating
● i18n Support basePath › serverless mode › should use correct default locale for locale domains
● i18n Support basePath › serverless mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › serverless mode › should handle locales with domain
● i18n Support basePath › serverless mode › should provide correctly defaultLocale for locale domain
● i18n Support basePath › serverless mode › should generate AMP pages with all locales
● i18n Support basePath › serverless mode › should work with AMP first page with all locales
● i18n Support basePath › serverless mode › should generate fallbacks with all locales
● i18n Support basePath › serverless mode › should generate auto-export page with all locales
● i18n Support basePath › serverless mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › serverless mode › should not output GSP pages that returned notFound
● i18n Support basePath › serverless mode › should 404 for GSP pages that returned notFound
● i18n Support basePath › serverless mode › should transition on client properly for page that starts with locale
● i18n Support basePath › serverless mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › serverless mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › serverless mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › serverless mode › should use default locale for / without accept-language
● i18n Support basePath › serverless mode › should load getStaticProps page correctly SSR
● i18n Support basePath › serverless mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › serverless mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › serverless mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › serverless mode › should navigate client side for default locale with no prefix
● i18n Support basePath › serverless mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › serverless mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › serverless mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › serverless mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › serverless mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › serverless mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › serverless mode › should navigate to another page and back correctly with locale
● i18n Support basePath › serverless mode › should navigate to getStaticProps page and back correctly with locale
● i18n Support basePath › with localeDetection disabled › should not detect locale from accept-language
● i18n Support basePath › with localeDetection disabled › should set locale from detected path
|
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 10.8s | 10.6s | -210ms |
nodeModulesSize | 85 MB | 85.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.366 | 2.378 | |
/ avg req/sec | 1056.61 | 1051.38 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.384 | 1.4 | |
/error-in-render avg req/sec | 1806.23 | 1786.06 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 13.3s | 12.6s | -632ms |
nodeModulesSize | 85 MB | 85.5 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_error.js | 996 kB | 996 kB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 996 kB | 996 kB | ✓ |
link.js | 1.05 MB | 1.05 MB | ✓ |
routerDirect.js | 1.04 MB | 1.04 MB | ✓ |
withRouter.js | 1.04 MB | 1.04 MB | ✓ |
Overall change | 5.13 MB | 5.13 MB | ✓ |
Failing test suitesCommit: 1791fd1 test/integration/i18n-support/test/index.test.js
Expand output● i18n Support › production mode › should output correct prerender-manifest
● i18n Support › serverless mode › should output correct prerender-manifest
test/integration/i18n-support-base-path/test/index.test.js
Expand output● i18n Support basePath › production mode › should output correct prerender-manifest
● i18n Support basePath › serverless mode › should output correct prerender-manifest
|
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 9.2s | 9.3s | |
nodeModulesSize | 85 MB | 85.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.179 | 2.194 | |
/ avg req/sec | 1147.14 | 1139.33 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.358 | 1.394 | |
/error-in-render avg req/sec | 1841.16 | 1793.2 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 10.6s | 10.9s | |
nodeModulesSize | 85 MB | 85.5 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_error.js | 996 kB | 996 kB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 996 kB | 996 kB | ✓ |
link.js | 1.05 MB | 1.05 MB | ✓ |
routerDirect.js | 1.04 MB | 1.04 MB | ✓ |
withRouter.js | 1.04 MB | 1.04 MB | ✓ |
Overall change | 5.13 MB | 5.13 MB | ✓ |
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 9.2s | 8.8s | -432ms |
nodeModulesSize | 85 MB | 85.5 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.043 | 2.026 | -0.02 |
/ avg req/sec | 1223.98 | 1233.66 | +9.68 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.176 | 1.149 | -0.03 |
/error-in-render avg req/sec | 2126.4 | 2176.39 | +49.99 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 10.7s | 10.6s | -109ms |
nodeModulesSize | 85 MB | 85.5 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-90b3d5a..55ad.js gzip | 6.54 kB | 6.54 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_error.js | 996 kB | 996 kB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 996 kB | 996 kB | ✓ |
link.js | 1.05 MB | 1.05 MB | ✓ |
routerDirect.js | 1.04 MB | 1.04 MB | ✓ |
withRouter.js | 1.04 MB | 1.04 MB | ✓ |
Overall change | 5.13 MB | 5.13 MB | ✓ |
FYI this also requires either Node 12 with full ICU or |
@longlho Go for the polyfill (with capability detection). Currently, NextJS targets Node |
@arguiot I'm deferring to the vercel team on this decision. Selective polyfill for Intl is non-trivial and potentially adds runtime complexity. |
Part of the issue is if you polyfill too many locales it'll OOM your Node process. Edit: it seems to not be relevant in this case since Intl.Locale is a fixed polyfill that doesn't require locale data. |
Where exactly do you need Also, tell me if I'm wrong, but if we add the For older versions, it's clear that the performance won't be as good. Let's see what the Vercel teams says but I don't think we have the choice unfortunately... I think that upgrading the minimum requirements is never a good idea. |
Node 10 is about to be EOL in 5 months. It's been in maintenance LTS for a while. You typically don't run production on older Node unless you're in fintech. |
But it's kind of the same thing you reproached me with my locale resolution algorithm. Here's the thing: there will be someone who will use Node 10 with NextJS. I agree that it would be easier to just ignore this case. But I'm not convinced it's the right thing to do. The answer would have been different if we were 5 months from now, but as long as Node 10 is used and supported, even by a minority of Next users, I think we should continue backward compatibility. Finally, even if Node 10 is discontinued, we must not forget that there is Node 11 between Node 10 and 12, which extends the list of users concerned. |
Node 11 is not a LTS version. Anw vercel team should make a decision on this. |
@Timer @lfades @timneutkens @ijjk Any updates on this decision? The TLDR of the discussion is that longlho needs to use a feature only available on Node 12 ( |
I just realized that |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 8.8s | 9s | |
nodeModulesSize | 82.4 MB | 83 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.079 | 2.088 | |
/ avg req/sec | 1202.31 | 1197.14 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.101 | 1.12 | |
/error-in-render avg req/sec | 2270.86 | 2231.37 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..0679.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-008bb91..b823.js gzip | 6.56 kB | 6.56 kB | ✓ |
webpack-95c2..e870.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.1 kB | 59.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-d3..23f6.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-0d19cb6..5497.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-2cf0e..a0a0.js gzip | 3.69 kB | 3.69 kB | ✓ |
hooks-42456f..0c06.js gzip | 887 B | 887 B | ✓ |
index-8081ce..e44f.js gzip | 227 B | 227 B | ✓ |
link-0ab9f83..fa00.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..c3d8.js gzip | 303 B | 303 B | ✓ |
withRouter-0..a68e.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.31 kB | 8.31 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 615 B | 615 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 609 B | 609 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 10.4s | 10.3s | -77ms |
nodeModulesSize | 82.4 MB | 83 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..0679.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-008bb91..b823.js gzip | 6.56 kB | 6.56 kB | ✓ |
webpack-95c2..e870.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.1 kB | 59.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-d3..23f6.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-0d19cb6..5497.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-2cf0e..a0a0.js gzip | 3.69 kB | 3.69 kB | ✓ |
hooks-42456f..0c06.js gzip | 887 B | 887 B | ✓ |
index-8081ce..e44f.js gzip | 227 B | 227 B | ✓ |
link-0ab9f83..fa00.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..c3d8.js gzip | 303 B | 303 B | ✓ |
withRouter-0..a68e.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.31 kB | 8.31 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.16 MB | 5.16 MB | ✓ |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 11s | 11.1s | |
nodeModulesSize | 42.6 MB | 43.2 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.249 | 2.358 | |
/ avg req/sec | 1111.68 | 1060.44 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.588 | 1.652 | |
/error-in-render avg req/sec | 1574.64 | 1513.25 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..854c.js gzip | 13.2 kB | 13.2 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 6.65 kB | 6.65 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.6 kB | 59.6 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
amp-e3e9bc99..932c.js gzip | 536 B | 536 B | ✓ |
hooks-5023ef..3670.js gzip | 888 B | 888 B | ✓ |
index-3a2b03..c677.js gzip | 227 B | 227 B | ✓ |
link-177412b..043e.js gzip | 1.67 kB | 1.67 kB | ✓ |
routerDirect..1a66.js gzip | 303 B | 303 B | ✓ |
withRouter-9..1b7d.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.66 kB | 8.66 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 347 B | 347 B | ✓ |
Overall change | 347 B | 347 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 613 B | 613 B | ✓ |
link.html gzip | 620 B | 620 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 12.9s | 12.9s | |
nodeModulesSize | 42.6 MB | 43.2 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
677f882d2ed8..854c.js gzip | 13.2 kB | 13.2 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 6.65 kB | 6.65 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.6 kB | 59.6 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
amp-e3e9bc99..932c.js gzip | 536 B | 536 B | ✓ |
hooks-5023ef..3670.js gzip | 888 B | 888 B | ✓ |
index-3a2b03..c677.js gzip | 227 B | 227 B | ✓ |
link-177412b..043e.js gzip | 1.67 kB | 1.67 kB | ✓ |
routerDirect..1a66.js gzip | 303 B | 303 B | ✓ |
withRouter-9..1b7d.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.66 kB | 8.66 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 347 B | 347 B | ✓ |
Overall change | 347 B | 347 B | ✓ |
Serverless bundles
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_error.js | 1.01 MB | 1.01 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
500.html | 2.65 kB | 2.65 kB | ✓ |
amp.amp.html | 10.4 kB | 10.4 kB | ✓ |
amp.html | 1.86 kB | 1.86 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1.01 MB | 1.01 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.06 MB | 1.06 MB | ✓ |
withRouter.js | 1.06 MB | 1.06 MB | ✓ |
Overall change | 5.21 MB | 5.21 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
buildDuration | 12.8s | 13.1s | |
nodeModulesSize | 42.6 MB | 43.2 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.1 | 2.12 | |
/ avg req/sec | 1190.4 | 1179.38 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.453 | 1.462 | |
/error-in-render avg req/sec | 1721.12 | 1709.96 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
597-dc8125e2..ef24.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 954 B | 954 B | ✓ |
Overall change | 60 kB | 60 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_app-aedc815..1421.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error-71ec2..1a96.js gzip | 3.38 kB | 3.38 kB | ✓ |
amp-33a09cb0..6745.js gzip | 536 B | 536 B | ✓ |
hooks-4e968a..f870.js gzip | 902 B | 902 B | ✓ |
index-5c6845..f75c.js gzip | 230 B | 230 B | ✓ |
link-99f0c6c..b84a.js gzip | 1.65 kB | 1.65 kB | ✓ |
routerDirect..bb56.js gzip | 306 B | 306 B | ✓ |
withRouter-7..2133.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.57 kB | 8.57 kB | ✓ |
Client Build Manifests
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
_buildManifest.js gzip | 326 B | 326 B | ✓ |
Overall change | 326 B | 326 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | longlho/next.js locale | Change | |
---|---|---|---|
index.html gzip | 585 B | 585 B | ✓ |
link.html gzip | 591 B | 591 B | ✓ |
withRouter.html gzip | 579 B | 579 B | ✓ |
Overall change | 1.75 kB | 1.75 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "1Ejceog8AxXoKLIU9_h-C",
+ "buildId": "1VeOG9S_aUoRvSRzNwFCi",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/1Ejceog8AxXoKLIU9_h-C/_buildManifest.js"
+ src="/_next/static/1VeOG9S_aUoRvSRzNwFCi/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/1Ejceog8AxXoKLIU9_h-C/_ssgManifest.js"
+ src="/_next/static/1VeOG9S_aUoRvSRzNwFCi/_ssgManifest.js"
async=""
></script>
</body>
Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "1Ejceog8AxXoKLIU9_h-C",
+ "buildId": "1VeOG9S_aUoRvSRzNwFCi",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/1Ejceog8AxXoKLIU9_h-C/_buildManifest.js"
+ src="/_next/static/1VeOG9S_aUoRvSRzNwFCi/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/1Ejceog8AxXoKLIU9_h-C/_ssgManifest.js"
+ src="/_next/static/1VeOG9S_aUoRvSRzNwFCi/_ssgManifest.js"
async=""
></script>
</body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "1Ejceog8AxXoKLIU9_h-C",
+ "buildId": "1VeOG9S_aUoRvSRzNwFCi",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/1Ejceog8AxXoKLIU9_h-C/_buildManifest.js"
+ src="/_next/static/1VeOG9S_aUoRvSRzNwFCi/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/1Ejceog8AxXoKLIU9_h-C/_ssgManifest.js"
+ src="/_next/static/1VeOG9S_aUoRvSRzNwFCi/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: 1301b55 test/integration/i18n-support-base-path/test/index.test.js
Expand output● i18n Support basePath › dev mode › should navigate to page with same name as development buildId
● i18n Support basePath › dev mode › should navigate through history with query correctly
● i18n Support basePath › dev mode › should have correct values for non-prefixed path
● i18n Support basePath › dev mode › should not have hydration mis-match from hash
● i18n Support basePath › dev mode › should navigate to auto-export dynamic page
● i18n Support basePath › dev mode › should navigate with locale prop correctly
● i18n Support basePath › dev mode › should navigate with locale prop correctly GSP
● i18n Support basePath › dev mode › should navigate with locale false correctly
● i18n Support basePath › dev mode › should navigate with locale false correctly GSP
● i18n Support basePath › dev mode › should update asPath on the client correctly
● i18n Support basePath › dev mode › should use correct default locale for locale domains
● i18n Support basePath › dev mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › dev mode › should provide defaultLocale correctly for locale domain
● i18n Support basePath › dev mode › should generate AMP pages with all locales
● i18n Support basePath › dev mode › should work with AMP first page with all locales
● i18n Support basePath › dev mode › should generate auto-export page with all locales
● i18n Support basePath › dev mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › dev mode › should transition on client properly for page that starts with locale
● i18n Support basePath › dev mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › dev mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › dev mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › dev mode › should use default locale for / without accept-language
● i18n Support basePath › dev mode › should load getStaticProps page correctly SSR
● i18n Support basePath › dev mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › dev mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › dev mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › dev mode › should navigate client side for default locale with no prefix
● i18n Support basePath › dev mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › dev mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › dev mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › dev mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › dev mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › dev mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › dev mode › should navigate to another page and back correctly with locale
● i18n Support basePath › dev mode › should navigate to getStaticProps page and back correctly with locale
● i18n Support basePath › production mode › should navigate to page with same name as development buildId
● i18n Support basePath › production mode › should redirect to locale domain correctly client-side
● i18n Support basePath › production mode › should render the correct href for locale domain
● i18n Support basePath › production mode › should render the correct href with locale domains but not on a locale domain
● i18n Support basePath › production mode › should navigate through history with query correctly
● i18n Support basePath › production mode › should not contain backslashes in pages-manifest
● i18n Support basePath › production mode › should resolve href correctly when dynamic route matches locale prefixed
● i18n Support basePath › production mode › should use default locale when no locale is in href with locale false
● i18n Support basePath › production mode › should preload all locales data correctly
● i18n Support basePath › production mode › should have correct values for non-prefixed path
● i18n Support basePath › production mode › should not have hydration mis-match from hash
● i18n Support basePath › production mode › should add i18n config to routes-manifest
● i18n Support basePath › production mode › should output correct prerender-manifest
● i18n Support basePath › production mode › should resolve auto-export dynamic route correctly
● i18n Support basePath › production mode › should navigate to auto-export dynamic page
● i18n Support basePath › production mode › should apply trailingSlash redirect correctly
● i18n Support basePath › production mode › should apply redirects correctly
● i18n Support basePath › production mode › should apply headers correctly
● i18n Support basePath › production mode › should visit API route directly correctly
● i18n Support basePath › production mode › should visit dynamic API route directly correctly
● i18n Support basePath › production mode › should rewrite to API route correctly
● i18n Support basePath › production mode › should apply rewrites correctly
● i18n Support basePath › production mode › should navigate with locale prop correctly
● i18n Support basePath › production mode › should navigate with locale prop correctly GSP
● i18n Support basePath › production mode › should navigate with locale false correctly
● i18n Support basePath › production mode › should navigate with locale false correctly GSP
● i18n Support basePath › production mode › should update asPath on the client correctly
● i18n Support basePath › production mode › should handle fallback correctly after generating
● i18n Support basePath › production mode › should use correct default locale for locale domains
● i18n Support basePath › production mode › should not strip locale prefix for default locale with locale domains
● i18n Support basePath › production mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › production mode › should redirect to correct locale domain
● i18n Support basePath › production mode › should handle locales with domain
● i18n Support basePath › production mode › should provide defaultLocale correctly for locale domain
● i18n Support basePath › production mode › should generate AMP pages with all locales
● i18n Support basePath › production mode › should work with AMP first page with all locales
● i18n Support basePath › production mode › should generate fallbacks with all locales
● i18n Support basePath › production mode › should generate auto-export page with all locales
● i18n Support basePath › production mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › production mode › should not output GSP pages that returned notFound
● i18n Support basePath › production mode › should 404 for GSP pages that returned notFound
● i18n Support basePath › production mode › should transition on client properly for page that starts with locale
● i18n Support basePath › production mode › should 404 for GSP that returned notFound on client-transition
● i18n Support basePath › production mode › should render 404 for fallback page that returned 404 on client transition
● i18n Support basePath › production mode › should render 404 for fallback page that returned 404
● i18n Support basePath › production mode › should render 404 for blocking fallback page that returned 404 on client transition
● i18n Support basePath › production mode › should render 404 for blocking fallback page that returned 404
● i18n Support basePath › production mode › should not remove locale prefix for default locale
● i18n Support basePath › production mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › production mode › should redirect to locale prefixed route for /
● i18n Support basePath › production mode › should use default locale for / without accept-language
● i18n Support basePath › production mode › should load getStaticProps page correctly SSR
● i18n Support basePath › production mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › production mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should navigate client side for default locale with no prefix
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › production mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › production mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › production mode › should navigate to another page and back correctly with locale
● i18n Support basePath › production mode › should navigate to getStaticProps page and back correctly with locale
● i18n Support basePath › serverless mode › should have correct props for blocking notFound
● i18n Support basePath › serverless mode › should resolve rewrites correctly
● i18n Support basePath › serverless mode › should navigate to page with same name as development buildId
● i18n Support basePath › serverless mode › should redirect to locale domain correctly client-side
● i18n Support basePath › serverless mode › should render the correct href for locale domain
● i18n Support basePath › serverless mode › should render the correct href with locale domains but not on a locale domain
● i18n Support basePath › serverless mode › should navigate through history with query correctly
● i18n Support basePath › serverless mode › should not contain backslashes in pages-manifest
● i18n Support basePath › serverless mode › should resolve href correctly when dynamic route matches locale prefixed
● i18n Support basePath › serverless mode › should use default locale when no locale is in href with locale false
● i18n Support basePath › serverless mode › should preload all locales data correctly
● i18n Support basePath › serverless mode › should have correct values for non-prefixed path
● i18n Support basePath › serverless mode › should not have hydration mis-match from hash
● i18n Support basePath › serverless mode › should add i18n config to routes-manifest
● i18n Support basePath › serverless mode › should output correct prerender-manifest
● i18n Support basePath › serverless mode › should resolve auto-export dynamic route correctly
● i18n Support basePath › serverless mode › should navigate to auto-export dynamic page
● i18n Support basePath › serverless mode › should apply trailingSlash redirect correctly
● i18n Support basePath › serverless mode › should apply redirects correctly
● i18n Support basePath › serverless mode › should apply headers correctly
● i18n Support basePath › serverless mode › should visit API route directly correctly
● i18n Support basePath › serverless mode › should visit dynamic API route directly correctly
● i18n Support basePath › serverless mode › should rewrite to API route correctly
● i18n Support basePath › serverless mode › should apply rewrites correctly
● i18n Support basePath › serverless mode › should navigate with locale prop correctly
● i18n Support basePath › serverless mode › should navigate with locale prop correctly GSP
● i18n Support basePath › serverless mode › should navigate with locale false correctly
● i18n Support basePath › serverless mode › should navigate with locale false correctly GSP
● i18n Support basePath › serverless mode › should update asPath on the client correctly
● i18n Support basePath › serverless mode › should handle fallback correctly after generating
● i18n Support basePath › serverless mode › should use correct default locale for locale domains
● i18n Support basePath › serverless mode › should not strip locale prefix for default locale with locale domains
● i18n Support basePath › serverless mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › serverless mode › should redirect to correct locale domain
● i18n Support basePath › serverless mode › should handle locales with domain
● i18n Support basePath › serverless mode › should provide defaultLocale correctly for locale domain
● i18n Support basePath › serverless mode › should generate AMP pages with all locales
● i18n Support basePath › serverless mode › should work with AMP first page with all locales
● i18n Support basePath › serverless mode › should generate fallbacks with all locales
● i18n Support basePath › serverless mode › should generate auto-export page with all locales
● i18n Support basePath › serverless mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › serverless mode › should not output GSP pages that returned notFound
● i18n Support basePath › serverless mode › should 404 for GSP pages that returned notFound
● i18n Support basePath › serverless mode › should transition on client properly for page that starts with locale
● i18n Support basePath › serverless mode › should 404 for GSP that returned notFound on client-transition
● i18n Support basePath › serverless mode › should render 404 for fallback page that returned 404 on client transition
● i18n Support basePath › serverless mode › should render 404 for fallback page that returned 404
● i18n Support basePath › serverless mode › should render 404 for blocking fallback page that returned 404 on client transition
● i18n Support basePath › serverless mode › should render 404 for blocking fallback page that returned 404
● i18n Support basePath › serverless mode › should not remove locale prefix for default locale
● i18n Support basePath › serverless mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › serverless mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › serverless mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › serverless mode › should redirect to locale prefixed route for /
● i18n Support basePath › serverless mode › should use default locale for / without accept-language
● i18n Support basePath › serverless mode › should load getStaticProps page correctly SSR
● i18n Support basePath › serverless mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › serverless mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › serverless mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › serverless mode › should navigate client side for default locale with no prefix
● i18n Support basePath › serverless mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › serverless mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › serverless mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › serverless mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › serverless mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › serverless mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › serverless mode › should navigate to another page and back correctly with locale
● i18n Support basePath › serverless mode › should navigate to getStaticProps page and back correctly with locale
● i18n Support basePath › with localeDetection disabled › should have localeDetection in routes-manifest
● i18n Support basePath › with localeDetection disabled › should not detect locale from accept-language
● i18n Support basePath › with localeDetection disabled › should set locale from detected path
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
|
cc @arguiot @timneutkens
Fixes #18676