Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: App Fetch Compatibility for Older SC Versions #63

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

victorkl400
Copy link
Collaborator

Description

This PR updates the app fetching logic to check response for unendorsed apps which ensure compatibility with older smart contract versions that do not support endorsements.

Fixes #62

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

Screen Recording

Mainnet (X2EarnApps V3)

Screen.Recording.2025-01-31.at.11.51.15.mov

Testnet (X2EarnApps V1)

Screen.Recording.2025-01-31.at.11.51.55.mov

@victorkl400 victorkl400 self-assigned this Jan 31, 2025
@Agilulfo1820
Copy link
Member

Pushed a commit to not show vbd apps on testnet

@Agilulfo1820 Agilulfo1820 merged commit 1e1e079 into main Feb 3, 2025
4 checks passed
@Agilulfo1820 Agilulfo1820 deleted the fix/testnet-get-apps branch February 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - kit - explore ecosystem does not load vbd apps on testnet
2 participants