Fix: Truncate domain on Account #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,7 +38,7 @@ export const AccountSelector = ({ | |||
| rounded="full" | |||
| /> | |||
| <Text fontSize={size} fontWeight="500"> | |||
| {wallet?.domain || | |||
| {humanDomain(wallet?.domain ?? '', 6, 4) || | |||
There was a problem hiding this comment.
I was previously already doing it but with smaller names the output was kind of weird. Let me try this pr locally
There was a problem hiding this comment.
Increased allowed letters to 11, 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Truncate the domain if present to prevent UI breakage and ensure horizontal icons remain within the viewport
Type of change
Please delete options that are not relevant.
Checklist:
Screenshot
BEFORE
AFTER