Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize segmenter #3300

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Stabilize segmenter #3300

merged 2 commits into from
Apr 13, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Apr 13, 2023 •
edited
Loading

Fixes #2259

@jira-pull-request-webhook

This comment was marked as spam.

Sign in to view
@robertbastian robertbastian marked this pull request as ready for review April 13, 2023 14:00
Manishearth
Manishearth previously approved these changes Apr 13, 2023
View reviewed changes
sffc
sffc approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you for doing this

@robertbastian robertbastian merged commit 2a08a9a into unicode-org:main Apr 13, 2023
@robertbastian robertbastian deleted the seg branch April 13, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@aethanyc aethanyc Awaiting requested review from aethanyc aethanyc is a code owner

@makotokato makotokato Awaiting requested review from makotokato makotokato is a code owner

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Segmenter to Components
3 participants
@robertbastian @sffc @Manishearth