Show that we can use modern syntax in the documentation #507
+16
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmukuthu
reviewed
Sep 5, 2018
| } | ||
| ); | ||
| expect(() => { | ||
| this.foo.bar(); |
There was a problem hiding this comment.
this one probably needs to stay as was :)
|
Should we try to get this completed for v11? |
|
@papandreou think these new example are very clean, but I don't think this need be a release blocker - we can always follow up with this. |
sunesimonsen
force-pushed
the
ssimonsen/modern-syntax-in-example
branch
from
d88ce9c to
fb685af
Compare
sunesimonsen
force-pushed
the
ssimonsen/modern-syntax-in-example
branch
from
fb685af to
c2a0d4e
Compare
sunesimonsen
changed the title
msiebuhr
reviewed
Jan 10, 2019
| ); | ||
| expect(() => { | ||
| throw new Error('The error message'); | ||
| }, 'to throw', 'The error message'); |
There was a problem hiding this comment.
Personally, I find arrow-funcs spanning several lines can be quite difficult to read. I generally tend towards:
expect(
() => { throw new Error("The error message"); },
"to throw", "The error message"
);There was a problem hiding this comment.
We should aim at formatting te documentation with prettier. So whatever it decides.
There was a problem hiding this comment.
It says:
expect(
() => {
throw new Error('The error message');
},
'to throw',
'The error message'
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show that we can use modern syntax in the documentation