Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cow swap cash out #390

Open
wants to merge 22 commits into
base: development
Choose a base branch
from
Open

cow swap cash out #390

wants to merge 22 commits into from

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Mar 10, 2025

Resolves #386

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 10, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Preview Deployment
6e82959140c71c4fb97ec689290dac310503d014

@zugdev
Copy link
Contributor Author

zugdev commented Mar 10, 2025 •
edited
Loading

QA:

cowswap-qa.mp4

Still have to QA the swap part here, not as easy cause there is no way to mock settlements other than deploying CowSwap in Anvil or Sepolia. Will probably do it with my own live funds.

@zugdev zugdev marked this pull request as ready for review March 10, 2025 06:17
@zugdev
Copy link
Contributor Author

zugdev commented Mar 10, 2025

I will also add a slippage text so the user knows how much they are losing on the swap (in case of low liquidity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cow Swap Cash Out
1 participant
@zugdev