Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Android-specific portions from base RxJava-only libs #127

Closed
dlew opened this issue Jun 14, 2016 · 3 comments
Closed

Split out Android-specific portions from base RxJava-only libs #127

dlew opened this issue Jun 14, 2016 · 3 comments

Comments

@dlew
Copy link
Contributor

dlew commented Jun 14, 2016

Right now RxLifecycle could be composed of two parts:

  1. The basic lifecycle/event system, with any input.
  2. The Android-specific system, with Activities/Fragments as input.

It'd be better if we split these into two modules, so people could use the lifecycle behavior separately from Android.

@felipecsl
Copy link

👍 that's exactly what we did in RxGroups, 2 separate artifacts, 1 java only, 1 android lib

@krn1
Copy link

krn1 commented Jun 15, 2016

I like this idea too

On Wed, Jun 15, 2016 at 3:25 AM, Felipe Lima [email protected]
wrote:

👍 that's exactly what we did in RxGroups, 2 separate artifacts, 1 java
only, 1 android lib


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#127 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ASrNdSRd77xaE2qhALRc_43LryhjmvPTks5qL9M0gaJpZM4I1X57
.

@dlew
Copy link
Contributor Author

dlew commented Aug 24, 2016

Done in #143

@dlew dlew closed this as completed Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants