Resolve issue of duplicate entries in Dicover tab #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towfiqi
requested changes
Mar 28, 2024
2) changing reduce and map together to make the code more readable. 3) ctr and position value rounded.
|
I make the changes |
|
This PR looks great, anything more to do here? |
No it's ready, waiting for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some time you get duplicates in the discover tab.
Analyse
It hapen when google search api get more then 1 entry for a device/country/keyword.
It is because the page is included in the dimentions of the google search console api call.
Solution
I have not change the api call because the data is stored locally and used also in other tabs (with the page dimension).
I grouped and sumerizing the stats in the Discover tab.
Remark : i included also an update of dev dependencies of react in package.json
(i actually, dont know how to make a separate pull request for it)