Run Cucumber feature tests on CI #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will probably fail. And this explains why the tests are taking so long (and failing) locally, but passing so fast on CI. Edit: awesome, they didn't! |
neilvcarvalho
changed the title
neilvcarvalho
force-pushed
the
nc-run-cucumber
branch
from
cd0e2e4 to
fa5193e
Compare
The CI builds are just too fast. We're only running RSpec and Minitest there, skipping the much slower Cucumber feature tests. This has happened because we broke the RSpec and Minitest runs into two different CI steps, forgetting Cucumber was there. This commit re-adds Cucumber as a separate step.
neilvcarvalho
force-pushed
the
nc-run-cucumber
branch
2 times, most recently
from
765199c to
ae99feb
Compare
neilvcarvalho
force-pushed
the
nc-run-cucumber
branch
from
ae99feb to
dd03f04
Compare
neilvcarvalho
force-pushed
the
nc-run-cucumber
branch
from
b9d5fc4 to
7830c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI builds are just too fast. We're only running RSpec and Minitest there, skipping the much slower Cucumber feature tests. This has happened because we broke the RSpec and Minitest runs into two different CI steps, forgetting Cucumber was there.
This commit re-adds Cucumber as a separate step.