Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fish shell #1952

Merged
merged 3 commits into from
Jan 20, 2025
Merged

feat: support fish shell #1952

merged 3 commits into from
Jan 20, 2025

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jan 18, 2025

To use fish:

# syntax=v1

def build():
    base(dev=True)
    shell('fish')
    install.conda()
    # install.conda(use_mamba=True)
    install.python()

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Keming <[email protected]>
@kemingy kemingy requested a review from Copilot January 18, 2025 11:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

pkg/lang/ir/v1/conda.go:186

  • Ensure that the new fish activation scripts for conda are covered by tests.
File(llb.Mkfile(fmt.Sprintf("%s/activate.fish", condaBinDir), 0755, []byte(condaActivateFish)),

pkg/lang/ir/v1/conda.go:210

  • Ensure that the new fish activation scripts for micromamba are covered by tests.
File(llb.Mkfile(fmt.Sprintf("%s/activate.fish", condaBinDir), 0755, []byte(mambaActivateFish)),
Signed-off-by: Keming <[email protected]>
@kemingy
Copy link
Member Author

kemingy commented Jan 18, 2025

I have no idea what happened to the e2e/cli/context_test. Manually running the moby/buildkit:rootless image with envd build succeeded.

@kemingy
Copy link
Member Author

kemingy commented Jan 20, 2025

The ci failure also happened to the main. Will merge this and solve it later.

@kemingy kemingy merged commit e737022 into tensorchord:main Jan 20, 2025
18 of 22 checks passed
@kemingy kemingy deleted the fish4 branch January 20, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support shell("fish")
2 participants