-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support fish shell #1952
feat: support fish shell #1952
Conversation
Signed-off-by: Keming <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Keming <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
pkg/lang/ir/v1/conda.go:186
- Ensure that the new fish activation scripts for conda are covered by tests.
File(llb.Mkfile(fmt.Sprintf("%s/activate.fish", condaBinDir), 0755, []byte(condaActivateFish)),
pkg/lang/ir/v1/conda.go:210
- Ensure that the new fish activation scripts for micromamba are covered by tests.
File(llb.Mkfile(fmt.Sprintf("%s/activate.fish", condaBinDir), 0755, []byte(mambaActivateFish)),
Signed-off-by: Keming <[email protected]>
I have no idea what happened to the |
The ci failure also happened to the main. Will merge this and solve it later. |
shell("fish")
#663To use fish: