Update max gRPC message size to 128 MB #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
requested review from
mfateev,
Sushisource,
alexshtin,
Spikhalskiy,
bergundy and
mmcshane
as code owners
Spikhalskiy
approved these changes
Apr 28, 2022
Spikhalskiy
reviewed
Apr 28, 2022
| @@ -455,7 +455,7 @@ type ( | |||
| // keepalive pings will be sent. | |||
| KeepAlivePermitWithoutStream bool | |||
|
|
|||
| // MaxPayloadSize is a number of bytes that gRPC would allow to travel to and from server. Defaults to 64 MB. | |||
| // MaxPayloadSize is a number of bytes that gRPC would allow to travel to and from server. Defaults to 128 MB. | |||
There was a problem hiding this comment.
Do we want to deprecate the setter?
There was a problem hiding this comment.
I had considered it, but I was having trouble justifying it. Are we hurt by this option being available and/or is it really important to us to remove the option? I definitely wouldn't add it if it wasn't already there, but if I just slap a "deprecated - please don't" it doesn't really do anything for us unless we're actually having trouble with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed default max gRPC message size to 128 MB from 64 MB.
Why?
To align with other SDKs and the server
Checklist