Remove namespace field from ScheduleActivityTaskCommandAttributes message #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
requested review from
mfateev,
Sushisource,
Spikhalskiy,
bergundy,
cretz and
mmcshane
as code owners
cretz
approved these changes
Apr 21, 2022
alexshtin
force-pushed
the
feature/remove-cross-ns-activity
branch
from
c5e1b22 to
5011f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Remove
namespacefield fromScheduleActivityTaskCommandAttributesmessage.Why?
See temporalio/api#174.
TODO
go.temporal.io/apiingo.modneeds to be updated as soon as above PR is merged.