Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix histogram naming in prometheus naming scope for tally #770

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix histogram naming in prometheus naming scope for tally #770

merged 1 commit into from
Mar 31, 2022

Conversation

naormatania
Copy link
Contributor

No description provided.

@cretz
Copy link
Member

cretz commented Mar 31, 2022

@naormatania - Thanks! I think the CLA needs to be signed before I merge this.

@naormatania
Copy link
Contributor Author

naormatania commented Mar 31, 2022 •
edited
Loading

@naormatania - Thanks! I think the CLA needs to be signed before I merge this.

How do I sign it ? I can't find here a link where I can sign it

EDIT: I think I have signed it

@cretz
Copy link
Member

cretz commented Mar 31, 2022

Thanks!

@cretz cretz merged commit fd0d1eb into temporalio:master Mar 31, 2022
@naormatania naormatania deleted the patch-1 branch March 31, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@mfateev mfateev Awaiting requested review from mfateev

@Sushisource Sushisource Awaiting requested review from Sushisource

@alexshtin alexshtin Awaiting requested review from alexshtin

@Spikhalskiy Spikhalskiy Awaiting requested review from Spikhalskiy

@bergundy bergundy Awaiting requested review from bergundy

@mmcshane mmcshane Awaiting requested review from mmcshane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naormatania @cretz