Add mock call assertions to TestWorkflowEnvironment #748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
AssertCalled
,AssertNotCalled
andAssertNumberOfCalls
toTestWorkflowEnvironment
to enable a straightforward way to assert for activity calls within workflows.They have been implemented following the same approach as https://pkg.go.dev/github.com/stretchr/testify/mock#Mock.
Why?
Asserting how an activity has been called from within a workflow (e.g. storing/retrieve data from a db) can be cumbersome without assertions on how mocks have been called.
The current best approach are:
The testify library provides
AssertCalled
,AssertNotCalled
andAssertNumberOfCalls
for this purpose, making the assertions straight-forward to understand and debug.Checklist
How was this tested:
Two unit tests have been implemented to test these cases.
Any docs updates needed?
In https://docs.temporal.io/docs/go/how-to-test-workflow-definitions-in-go/,
Test_SimpleWorkflow_ActivityParamCorrect
could be updated to read