Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for OnActivity about method references #691

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 7, 2022

What was changed

Extra doc added for TestWorkflowEnvironment.OnActivity

Why?

Per #688 and #586, people are trying to use references on a struct instead of references on an instance of a struct.

Checklist

  1. Closes Support receiver-less method refs in OnActivity mocks #688

@cretz cretz merged commit c32b047 into temporalio:master Jan 7, 2022
@cretz cretz deleted the mock-activity-method branch January 7, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support receiver-less method refs in OnActivity mocks
2 participants