Allow errors in signal interceptors #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitarb
requested review from
alexshtin,
mfateev,
Spikhalskiy and
Sushisource
as code owners
Sushisource
reviewed
Sep 29, 2021
Sushisource
reviewed
Sep 29, 2021
cretz
reviewed
Oct 1, 2021
| @@ -2249,7 +2249,7 @@ func (env *testWorkflowEnvironmentImpl) signalWorkflow(name string, input interf | |||
| panic(err) | |||
| } | |||
| env.postCallback(func() { | |||
| env.signalHandler(name, data) | |||
| _ = env.signalHandler(name, data) | |||
There was a problem hiding this comment.
I'm curious, this seems like a JetBrains-ism, is it? I don't think any traditional go tools have any problem with ignoring these returns.
There was a problem hiding this comment.
We have errorcheck linter, which complains if you ignore an error.
cretz
approved these changes
Oct 6, 2021
Sushisource
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Allowed errors in signal interceptors.
Why?
Previously there was no way to return an error from the signal interceptor, meaning that even if there is a problem signal would be processed anyways and it was impossible to interrupt the flow. This can be a problem in case if interceptor is doing some non-optional operations that have a chance to fail (e.g. network interactions).