Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local activity retry backoff #540

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

yiminc
Copy link
Member

@yiminc yiminc commented Sep 17, 2021

What was changed

Fix local activity retry backoff calculation.

Why?

Attempt used to start from 0, then it was changed to start from 1, but backoff calculation wasn't updated accordingly.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Copy link
Contributor

@vitarb vitarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant for local activity only, or should we change general retry logic here

next := float64(rc.initialInterval) * math.Pow(rc.backoffCoefficient, float64(attempt))
as well?

@yiminc yiminc merged commit ca2954d into temporalio:master Sep 17, 2021
@yiminc
Copy link
Member Author

yiminc commented Sep 17, 2021

@vitarb , the backoff changed in this PR is only used by local activity and the unit test framework to calculate activity/workflow retry backoff in unit test. I'm not sure about the grpc_retry as I don't know what is the attempt used there. It is worth double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants