Start worker even when no workflow/activity registered #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
requested review from
alexshtin,
mfateev,
Sushisource and
vitarb
as code owners
yiminc
force-pushed
the
start_worker
branch
from
304900a to
3155f99
Compare
Sushisource
approved these changes
Sep 16, 2021
yiminc
commented
Sep 17, 2021
| @@ -159,7 +159,7 @@ func (s *CacheEvictionSuite) TestResetStickyOnEviction() { | |||
| s.service.EXPECT().ResetStickyTaskQueue(gomock.Any(), gomock.Any()).DoAndReturn(mockResetStickyTaskQueue).Times(1) | |||
|
|
|||
| client := internal.NewServiceClient(s.service, nil, internal.ClientOptions{}) | |||
| workflowWorker := internal.NewAggregatedWorker(client, "taskqueue", worker.Options{}) | |||
| workflowWorker := internal.NewAggregatedWorker(client, "taskqueue", worker.Options{LocalActivityWorkerOnly: true}) | |||
There was a problem hiding this comment.
This test requires workflow worker only and the mock service is setup accordingly. If we start activity worker, the mock would complain. The test works because this test does not register any activity and as side effect, activity worker does not start. With the change in this PR, activity worker would start and this test failed. Fix is to explicitly disable activity worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Do not skip worker start when registry is empty.
Why?
There are uses cases where registry happen after worker is started, for example in integration tests that you want to start worker as part of test setup where you don't know what to register yet.
This check only make sense when the registry was done via golang's init() func. Now registry is per worker and can be done after worker is started. The current behavior of silently skip worker start is inconvenient.