User Metadata set on start / desc #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does some but not all of #690 -- metadata query to follow in another PR |
|
Actually, looks like we need to follow up on temporalio/temporal#6412 (pub-ify the fields in Go SDK) to make this work properly with schedule creation too |
cretz
approved these changes
Jan 17, 2025
Comment on lines
+146
to
+147
| StaticSummary: staticSummary, | ||
| StaticDetails: staticDetails, |
There was a problem hiding this comment.
I wonder if there is value putting this information in the above structured print struct, though I don't mind it being separate
|
Going to wait on temporalio/sdk-go#1782 to be released (or can depend on unreleased version) so this can include schedules |
Sushisource
force-pushed
the
user-metadata
branch
from
1036a08 to
cd9b459
Compare
Sushisource
force-pushed
the
user-metadata
branch
from
cd9b459 to
0fa7489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
--static-summaryand--static-detailsto all workflow-start like operationsWhy?
Useful feature
Checklist
Closes
How was this tested:
Added tests
Any docs updates needed?