Forward metadata in proxy #167
Merged
+209
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
reviewed
Jun 5, 2024
|
|
||
| // Copy incoming header to outgoing if not already present in outgoing. We | ||
| // have confirmed in gRPC that incoming is a copy so we can mutate it. | ||
| incoming, _ := metadata.FromIncomingContext(ctx) |
There was a problem hiding this comment.
This isn't an error, this is whether it was present, and we don't care really in our case. incoming is a type wrapper of map[string][]string and .Delete is a wrapper around delete. So a nil incoming is safe.
|
|
||
| // Remove common headers and if there's nothing left, return early | ||
| incoming.Delete("user-agent") | ||
| incoming.Delete(":authority") |
There was a problem hiding this comment.
Is this supposed to have a colon?
There was a problem hiding this comment.
Yes, this is an HTTP/2 header
tdeebswihart
approved these changes
Jun 5, 2024
|
This should not be merged until after a Go SDK release is made with temporalio/sdk-go#1502. We did a type conversion in the Go SDK on options set here so we cannot release an API library version with this updated or SDK users will get compile errors. |
Quinn-With-Two-Ns
approved these changes
Jun 5, 2024
|
@cretz temporalio/sdk-go#1502 is included in |
|
Thanks! I will go ahead and merge this after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Today headers set by client do not flow through the proxy. This will now forward them by default.