Meta: Add condition to prior art in CONTRIBUTING.md #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlho
reviewed
Dec 1, 2020
sffc
changed the title
|
I added a section about payload size. PTAL |
longlho
approved these changes
Dec 4, 2020
longlho
reviewed
Dec 12, 2020
| 2. **Difficult to implement in userland:** Features in Intl must bring something to the table that a third-party library wouldn't be able to do with the same level of efficiency and performance. The champion can cite a heavy locale data dependency or a complex algorithm to satisfy this criterion. | ||
| 3. **Broad appeal:** The champion must demonstrate that their feature request is needed by a large number of smaller web apps or a smaller number of high-profile web apps (Calendar, Travel Booking, etc). As a rule of thumb, the champion should demonstrate that their new feature is at least as useful as an existing feature in ECMA-402. The champion can provide npm module statistics or a list of user requests to satisfy this criterion. Alternatively, the champion can make a case that their feature is critical for a multilingual web, even if it lacks broad appeal. | ||
| 1. **Prior Art** | ||
| 1. Our job is to bring features that i18n experts have already solved to JavaScript developers, not to invent new solutions to those problems. If the feature is not yet available in CLDR, ICU, or Unicode, the champion should start there before coming to ECMA-402. |
There was a problem hiding this comment.
I think this wording indicates that ICU/CLDR/Unicode are pre-requisites. Maybe change them to example prior arts instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #513