[TEP005][QOL] Add MontecarloRunner.spectrum_integrated #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a shortcut for obtaining an integrated spectrum for the wavelength grid defined in the configuration file. If incompatible configuration settings are detected, an IntegrationError is raised.
unoebauer
suggested changes
Jun 22, 2017
tardis/montecarlo/base.py
Outdated
| def spectrum_integrated(self): | ||
| return self.integrator.calculate_spectrum( | ||
| self.spectrum_frequency[:-1], | ||
| 1000) |
There was a problem hiding this comment.
The hardcoded 1000 is the resolution of the p-grid, right? If so, I think we should make this also a configuration variable.
There was a problem hiding this comment.
What name would you suggest for such a configuration option?
There was a problem hiding this comment.
something like impact_parameter_bins
|
@unoebauer I agree that it would be nice to have a config option for the p-values, so I would say that we put this as an item in the project todo - but that we merge this PR. |
talytha
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shortcut for obtaining an integrated spectrum for the
wavelength grid defined in the configuration file. If incompatible
configuration settings are detected, an IntegrationError is raised.