Add unit tests for the formal integral #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wkerzendorf This should be complete. Please give a quick review and merge if there is nothing to dicuss. |
wkerzendorf
reviewed
Jun 13, 2017
| oz, | ||
| oshell_id | ||
| ) | ||
| ntest.assert_equal(N, size[0]) |
There was a problem hiding this comment.
maybe change to aassert N == size[0]
Make it clear when asserting the equality of two scalar values.
|
@wkerzendorf I made the changes you requested, please merge if there is nothing else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tests for the functions used bye the C implementation.