Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hdf path for time_of_simulation in sdec plot #2684

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix hdf path for time_of_simulation in sdec plot #2684

merged 1 commit into from
Jul 1, 2024

Conversation

sarthak-dv
Copy link
Contributor

📝 Description

Type: 🪲 bugfix

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@xansh xansh self-requested a review June 29, 2024 17:07
xansh
xansh approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@xansh xansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sarthak-dv sarthak-dv changed the title Fix hdf path for transport_state in sdec plot Fix hdf path for time_of_simulation in sdec plot Jun 29, 2024
@andrewfullard andrewfullard enabled auto-merge (squash) July 1, 2024 13:57
@andrewfullard andrewfullard merged commit e88a31a into tardis-sn:master Jul 1, 2024
10 checks passed
@sarthak-dv sarthak-dv deleted the sdec-hdf-fix branch July 1, 2024 16:34
sarthak-dv added a commit to sarthak-dv/tardis that referenced this pull request Jul 2, 2024
@sarthak-dv
Fix hdf path for time_of_simulation in sdec plot (tardis-sn#2684)
23bf146 
fix transport path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfullard andrewfullard andrewfullard approved these changes

@Knights-Templars Knights-Templars Knights-Templars approved these changes

@xansh xansh xansh approved these changes

Assignees

@sarthak-dv sarthak-dv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarthak-dv @andrewfullard @Knights-Templars @xansh