Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bot aliases in .mailmap #2038

Merged
merged 1 commit into from
May 31, 2022

Conversation

epassaro
Copy link
Member

📝 Description

Type: 🪲 bugfix

Used incorrect aliases in .mailmap on #2033.

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@epassaro epassaro requested a review from andrewfullard May 30, 2022 13:22
@epassaro epassaro force-pushed the ci/add-bot-mailmap-2 branch from bfe181c to 565ed39 Compare May 30, 2022 13:28
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #2038 (565ed39) into master (9d10e6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2038   +/-   ##
=======================================
  Coverage   59.88%   59.88%           
=======================================
  Files          70       70           
  Lines        8154     8154           
=======================================
  Hits         4883     4883           
  Misses       3271     3271           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andrewfullard
Copy link
Contributor

Sorry for not catching this earlier.

@andrewfullard andrewfullard merged commit 8b2bd60 into tardis-sn:master May 31, 2022
epassaro added a commit to epassaro/tardis that referenced this pull request Jun 2, 2022
epassaro added a commit to epassaro/tardis that referenced this pull request Jun 2, 2022
* Fix bot aliases in .mailmap (tardis-sn#2038)

* Added v_inner and v_outer, enable_nonhomologous_expansion for future use in nonhomologous expansion (tardis-sn#2024)

* added v_outer and v_inner to NumbaModel

* defined default value for v_inner and v_outer in NumbaModel

* added enable_nonhomologous_expansion to io/schemas/montecarlo.yml

* added v_inner and v_outer to NumbaPlasma

* added v_inner and v_outer as arguments for NumbaModel in run() in montecarlo_numba

* added v_outer_cgs to MonteCarloRunner

* removed a comment

* ran black on the changed files

* added right arguments in test

* added v_inner, v_outer to tests

* added temporary fix to formal_integral.py

* ran black on modified files

* changed dummy values in the test

* Reverted content of file.

* made needed change in test_cuda_formal_integral.py

* made needed change in test_numba_formal_integral.py

* Update README.rst in post-release (tardis-sn#2037)

* Fix docs badge

* Add license badge

* First attempt of creating credits.rst and README.rst via templates

* Working version

* Restore old README.rst

* Update post-release workflow

* Change .gitignore

* Various fixes

* Check PEP8 on CI (tardis-sn#2039)

* Add Flake8 job

* Change to file description

* Test payload

Co-authored-by: Sona Chitchyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants