Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the xlim and the ylabel (From PR #1646) #1711

Merged

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented Jul 13, 2021

I changed the xlim and y-axis name.
Description

The xlim was changed from 3000 to 9000 to 500 to 9000. The y-axis name was changed from Luminosity to Luminosity Density.
Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Rodot- Rodot- requested review from isaacgsmith, epassaro and andrewfullard and removed request for isaacgsmith July 13, 2021 14:28
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@isaacgsmith isaacgsmith requested review from andrewfullard and KevinCawley and removed request for epassaro July 13, 2021 14:31
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1711 (9aa610c) into master (60cd602) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1711   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files          63       63           
  Lines        5852     5852           
=======================================
  Hits         3621     3621           
  Misses       2231     2231           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cd602...9aa610c. Read the comment docs.

@isaacgsmith isaacgsmith requested a review from epassaro July 13, 2021 14:45
@andrewfullard andrewfullard merged commit c387e1e into tardis-sn:master Jul 14, 2021
@isaacgsmith isaacgsmith mentioned this pull request Jul 15, 2021
10 tasks
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants