Changed Formatting for the logger based on Log Level #1710

DhruvSondhi · 2021-07-13T14:09:12Z

This PR aims to add Logging Formatting based on log level. Debug Level has different formatting due to the number of messages that would be printed to the strerr. All other logging level follow the existing formatting (with the \n\t formatting).

Description

Motivation and context

How has this been tested?

Testing pipeline.
Other.

Examples

Type of change

Bug fix.
New feature.
Breaking change.
None of the above.

Checklist

My change requires a change to the documentation.
- I have updated the documentation accordingly.
- (optional) I have built the documentation on my fork following the instructions.
I have assigned and requested two reviewers for this pull request.

tardis-bot · 2021-07-13T14:09:32Z

Before a pull request is accepted, it must meet the following criteria:

Is the necessary information provided?
Is this a duplicate PR?
- If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
- If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
Does it pass existing tests and are new tests provided if required?
- The test coverage should not decrease, and for new features should be close to 100%.
Is the code tidy?
- No unnecessary print lines or code comments.

tardis-bot · 2021-07-13T14:09:32Z

Before a pull request is accepted, it must meet the following criteria:

Is the necessary information provided?
Is this a duplicate PR?
- If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
- If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
Does it pass existing tests and are new tests provided if required?
- The test coverage should not decrease, and for new features should be close to 100%.
Is the code tidy?
- No unnecessary print lines or code comments.

tardis/io/logger/logger.py

tardis/io/logger/colored_logger.py

DhruvSondhi

Explained some of the changes done in this PR.

codecov · 2021-07-13T14:21:28Z

Codecov Report

Merging #1710 (119ff8c) into master (1c3322b) will decrease coverage by 0.76%.
The diff coverage is n/a.

❗ Current head 119ff8c differs from pull request most recent head 82b1e79. Consider uploading reports for the commit 82b1e79 to get more accurate results

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
- Coverage   62.65%   61.89%   -0.77%     
==========================================
  Files          65       63       -2     
  Lines        6036     5855     -181     
==========================================
- Hits         3782     3624     -158     
+ Misses       2254     2231      -23

Impacted Files	Coverage Δ
tardis/tardis/io/logger/logger.py	`91.37% <0.00%> (-0.43%)`	⬇️
tardis/tardis/simulation/base.py	`82.88% <0.00%> (-0.29%)`	⬇️
tardis/tardis/io/atom_data/base.py	`89.77% <0.00%> (ø)`
tardis/tardis/scripts/cmfgen2tardis.py	`0.00% <0.00%> (ø)`
tardis/tardis/grid/base.py
...dis/tardis/visualization/tools/convergence_plot.py
tardis/tardis/io/logger/montecarlo_tracking.py
tardis/tardis/io/logger/montecarlo_logger.py	`59.25% <0.00%> (ø)`
tardis/tardis/visualization/widgets/shell_info.py	`96.00% <0.00%> (+0.04%)`	⬆️
tardis/tardis/base.py	`57.69% <0.00%> (+0.54%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea86abf...82b1e79. Read the comment docs.

tardis/io/atom_data/base.py

tardis/io/logger/colored_logger.py

tardis/io/logger/logger.py

DhruvSondhi · 2021-07-16T05:27:20Z

tardis/io/atom_data/base.py

@@ -164,7 +164,7 @@ def from_hdf(cls, fname=None):
                try:
                    dataframes[name] = store[name]
                except KeyError:
-                    logger.debug("Dataframe does not contain NAME column")
+                    logger.debug(f"Dataframe does not contain {name} column")


@andrewfullard @Rodot- This change needs to be merged. What should be done here? The PR will remain Draft.

review-notebook-app · 2021-08-09T06:24:53Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Removed redundant \n\t formatting from existing messages

DhruvSondhi requested review from andrewfullard, wkerzendorf and Rodot- July 13, 2021 14:09

DhruvSondhi added the logging label Jul 13, 2021

DhruvSondhi commented Jul 13, 2021

View reviewed changes

tardis/io/logger/logger.py Outdated Show resolved Hide resolved

DhruvSondhi commented Jul 13, 2021

View reviewed changes

tardis/io/logger/colored_logger.py Outdated Show resolved Hide resolved

DhruvSondhi commented Jul 13, 2021

View reviewed changes

DhruvSondhi force-pushed the debug_format_messg branch from 5ee178f to 4594c21 Compare July 13, 2021 14:24

andrewfullard reviewed Jul 13, 2021

View reviewed changes

tardis/io/atom_data/base.py Show resolved Hide resolved

tardis/io/logger/colored_logger.py Outdated Show resolved Hide resolved

tardis/io/logger/colored_logger.py Outdated Show resolved Hide resolved

tardis/io/logger/logger.py Outdated Show resolved Hide resolved

DhruvSondhi mentioned this pull request Jul 13, 2021

Removed Formatting from Existing Log Messages #1714

Merged

10 tasks

DhruvSondhi changed the title ~~Changed Formatting for the logger based on Log Level & Removed existing Formatting~~ Changed Formatting for the logger based on Log Level Jul 13, 2021

DhruvSondhi force-pushed the debug_format_messg branch from 9fb1795 to 4a4c337 Compare July 15, 2021 03:55

DhruvSondhi requested a review from andrewfullard July 15, 2021 03:57

DhruvSondhi marked this pull request as draft July 15, 2021 14:38

DhruvSondhi force-pushed the debug_format_messg branch from 4a4c337 to ade2f2f Compare July 15, 2021 17:30

DhruvSondhi commented Jul 16, 2021

View reviewed changes

DhruvSondhi force-pushed the debug_format_messg branch from ade2f2f to 5c6842e Compare July 17, 2021 15:01

DhruvSondhi force-pushed the debug_format_messg branch from fc2a451 to 5c6842e Compare August 9, 2021 06:27

DhruvSondhi added 3 commits August 9, 2021 11:57

Changed Formatting for the logger based on Log Level,

a869c41

Removed redundant \n\t formatting from existing messages

Reverted log message formatting

14aab0a

Restructured the colored logger for the log message format

82b1e79

DhruvSondhi force-pushed the debug_format_messg branch from 5c6842e to 82b1e79 Compare August 9, 2021 06:27

DhruvSondhi mentioned this pull request Jan 13, 2022

Option to change the formatting (colors) of the logs & Ability to create Log Files #1859

Open

wkerzendorf marked this pull request as ready for review February 23, 2022 16:22

wkerzendorf merged commit 52106be into tardis-sn:master Feb 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed Formatting for the logger based on Log Level #1710

Changed Formatting for the logger based on Log Level #1710

DhruvSondhi commented Jul 13, 2021 •

edited

Loading

tardis-bot commented Jul 13, 2021

tardis-bot commented Jul 13, 2021

DhruvSondhi left a comment

codecov bot commented Jul 13, 2021 •

edited

Loading

DhruvSondhi Jul 16, 2021

review-notebook-app bot commented Aug 9, 2021

Changed Formatting for the logger based on Log Level #1710

Changed Formatting for the logger based on Log Level #1710

Conversation

DhruvSondhi commented Jul 13, 2021 • edited Loading

tardis-bot commented Jul 13, 2021

tardis-bot commented Jul 13, 2021

DhruvSondhi left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 13, 2021 • edited Loading

Codecov Report

DhruvSondhi Jul 16, 2021

Choose a reason for hiding this comment

review-notebook-app bot commented Aug 9, 2021

DhruvSondhi commented Jul 13, 2021 •

edited

Loading

codecov bot commented Jul 13, 2021 •

edited

Loading