Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in credit to NumFOCUS support of TARDIS #1661

Closed
wants to merge 1 commit into from

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented Jun 21, 2021

Set the TARDIS acknowledgment to include NumFOCUS fiscal sponsorship

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@Rodot- Rodot- requested a review from wkerzendorf June 21, 2021 19:29
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #1661 (1b7530d) into master (ec5448d) will not change coverage.
The diff coverage is n/a.

❗ Current head 1b7530d differs from pull request most recent head 11e885b. Consider uploading reports for the commit 11e885b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   61.93%   61.93%           
=======================================
  Files          62       62           
  Lines        5729     5729           
=======================================
  Hits         3548     3548           
  Misses       2181     2181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5448d...11e885b. Read the comment docs.

@isaacgsmith
Copy link
Member

This is already done on #1656

@Rodot-
Copy link
Contributor Author

Rodot- commented Jun 21, 2021

This is already done on #1656

It looks like there's a couple small issues with the changes there and I've made some comments. I'll close this PR. I would suggest going with my change but we can discuss it over there.

@Rodot- Rodot- closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants