Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Update #1474

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Docs Update #1474

merged 1 commit into from
Mar 24, 2021

Conversation

ankur-soni97
Copy link
Contributor

@ankur-soni97 ankur-soni97 commented Mar 12, 2021

Description: Updated missing Z value of Oxygen in abundancecust.rst

Motivation and Context

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (Just completed the line seeing the pattern of doc)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1474 (0846acf) into master (50f13ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1474   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files          67       67           
  Lines        5523     5523           
=======================================
  Hits         3929     3929           
  Misses       1594     1594           
Impacted Files Coverage Δ
tardis/tardis/io/util.py 72.09% <0.00%> (ø)
tardis/tardis/montecarlo/base.py 86.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f13ba...3208fc7. Read the comment docs.

Copy link
Member

@isaacgsmith isaacgsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid. Just because I saw it missing on the checklist, even though it shouldn't make a difference with just the small change you made, it's a good habit to build the documentation when you make any changes to it.

@andrewfullard andrewfullard merged commit 110d8c9 into tardis-sn:master Mar 24, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants