Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore caching to spectrum_integrated #1227

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

arjunsavel
Copy link
Contributor

Description

I've uncommented a line that checked whether there was a cached version of the integrated spectrum.

Motivation and Context

Solves #1194

How Has This Been Tested?

N/A yet — will wait for Azure build

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #1227 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1227   +/-   ##
=======================================
  Coverage   77.71%   77.72%           
=======================================
  Files          91       91           
  Lines        5727     5728    +1     
=======================================
+ Hits         4451     4452    +1     
  Misses       1276     1276           
Impacted Files Coverage Δ
tardis/montecarlo/base.py 86.90% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7259178...634b085. Read the comment docs.

@arjunsavel arjunsavel linked an issue Jul 12, 2020 that may be closed by this pull request
@wkerzendorf wkerzendorf merged commit cd35df9 into master Jul 14, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore caching for spectrum_integrated
4 participants