-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes most SQL code #397
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 68.87% 59.84% -9.04%
==========================================
Files 31 25 -6
Lines 3733 2764 -969
==========================================
- Hits 2571 1654 -917
+ Misses 1162 1110 -52 ☔ View full report in Codecov by Sentry. |
Tests are failing. Did you miss removing some of the sqlalchemy tests? |
Fixed! |
*beep* *bop* Hi, human. The Click here to see your results. |
📝 Description
Type: ☣️
breaking change
This removes the SQL code and tests from Carsus. Fixes #182
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label