Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes most SQL code #397

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Removes most SQL code #397

merged 11 commits into from
Sep 4, 2024

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Aug 19, 2024

📝 Description

Type: ☣️ breaking change

This removes the SQL code and tests from Carsus. Fixes #182

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.84%. Comparing base (fc47fbd) to head (223bb2d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
carsus/io/output/base.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fc47fbd) and HEAD (223bb2d). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (fc47fbd) HEAD (223bb2d)
12 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   68.87%   59.84%   -9.04%     
==========================================
  Files          31       25       -6     
  Lines        3733     2764     -969     
==========================================
- Hits         2571     1654     -917     
+ Misses       1162     1110      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard mentioned this pull request Aug 27, 2024
2 tasks
@jvshields
Copy link
Contributor

Tests are failing. Did you miss removing some of the sqlalchemy tests?

@andrewfullard
Copy link
Contributor Author

Tests are failing. Did you miss removing some of the sqlalchemy tests?

Fixed!

Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@wkerzendorf wkerzendorf merged commit 1c2771b into master Sep 4, 2024
10 of 11 checks passed
@andrewfullard andrewfullard deleted the remove-sql-code branch September 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge SQL legacy code
3 participants