-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/typescript): Remove empty statements that const enum decls are folded into #10128
Conversation
🦋 Changeset detectedLatest commit: 6fa7994 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #10128 will degrade performances by 3.69%Comparing Summary
Benchmarks breakdown
|
I discarded the changes of stack traces because CI failed |
closes #10097
By searching
asEmbeddedStatement
in https://github.com/microsoft/TypeScript/blob/main/src/compiler/factory/nodeFactory.ts, we can know there are four cases where typescript doesn't insert an empty statement:Case 2, 3, 4 can be merged in
visit_mut_stmts
, while case 1 should be handled invisit_mut_module_items