Refactor payment sheet event tests

[tianzhao-stripe]

Summary

parameterizing some payment sheet event tests
factoring out defaultPaymentSuccessEventParams
made PaymentMethodFixtures.LINK_INLINE_PAYMENT_SELECTION

Motivation

Make testing easier.
Reduce technical debt.

Testing

• Added tests
• Modified tests
• Manually verified

Screenshots

N.A.

Changelog

N.A.

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.1 KiB │   6.1 KiB │  0 B │   5.9 KiB │   5.9 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +1 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +1 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20119 │ 20119 │ 0 (+0 -0) 
   types │  6224 │  6224 │ 0 (+0 -0) 
 classes │  5018 │  5018 │ 0 (+0 -0) 
 methods │ 30008 │ 30008 │ 0 (+0 -0) 
  fields │ 17362 │ 17362 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0

APK

   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.9 KiB │ +2 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 25.7 KiB │ +1 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 55.7 KiB │ +1 B │ 129.1 KiB │  0 B │ (total)

[amk-stripe]

The link inline change LGTM. I'm not convinced that the PaymentSheetEventTest change is a net-positive, left a comment about that.

Also a tip for the future: I think this could have been two PRs (one for the link inline changes, one for the changes to PaymentSheetEventTest). Just makes it easier to review and also for you to get your changes merged

[amk-stripe]

I'm not sure there's much of an advantage to making this change -- it doesn't improve the error message if tests fail at all and it makes our tests less explicit (ie it's harder to tell what exactly we are asserting on). It does reduce duplication, but at the cost of making the tests less explicit and I'm not sure the trade off is worth it.