impl EqualValues 2 objects have (T) Equal(T) bool
#1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensayshi
force-pushed
the
isequaller-reflection
branch
from
75f7699 to
7294ac7
Compare
rubensayshi
force-pushed
the
isequaller-reflection
branch
from
7294ac7 to
215beb6
Compare
|
We had to switch to https://github.com/google/go-cmp for the same reason. |
Do you mean that you integrated google's go-cmp with stretchr, or that you used go-cmp instead. I don't think that go-cmp is a replacement for stretchr. |
dolmen
added
enhancement
Breaking Change
pkg-assert
…mplement an `(T) Equal(T) bool` method, use the method to compare.
rubensayshi
force-pushed
the
isequaller-reflection
branch
from
215beb6 to
bb8e80e
Compare
|
rebased this old MR, I still think this is a good change! we've been using a fork for years now to have this change... we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when using
EqualValuesfor 2 objects which are of the same type and implement an(T) Equal(T) boolmethod, use the method to compare.Tbh I'd almost put this in
Equal, butEqualValuesis more correct...I chose not to implement supporting
EqualValues(Foo{1}, &Foo{1}), though I do have a branch with it implemented ...Motivation
This seems very much inline with many many other languages and makes it much easier to compare custom types, ranging from application level types to
decimal.Decimal.