Fixing LIBMODBUS_VERSION_HEX encoding #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The given definition for LIBMODBUS_VERSION_HEX is not coherent with the result given by the macro itself, which is left-shifted by an extra factor of 8 bits. For example, current implementation for version 1.2.3 would be encoded like 0x01020300 instead of 0x010203. You can either accept this pull request (breaking change here if someone did rely on this macro!!) or update the commented definition.
|
Thank you Giovanni. |
georgidimov
pushed a commit
to georgidimov/libmodbus
that referenced
this pull request
Jul 24, 2017
The result of LIBMODBUS_VERSION_HEX is left-shifted by an extra factor of 8 bits. For example, current implementation for version 1.2.3 would be encoded like 0x01020300 instead of 0x010203.
epsilonrt
pushed a commit
to epsilonrt/libmodbus
that referenced
this pull request
Jun 19, 2023
The result of LIBMODBUS_VERSION_HEX is left-shifted by an extra factor of 8 bits. For example, current implementation for version 1.2.3 would be encoded like 0x01020300 instead of 0x010203.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The given definition for LIBMODBUS_VERSION_HEX is not coherent with the result given by the macro itself, which is left-shifted by an extra factor of 8 bits.
For example, current implementation for version 1.2.3 would be encoded like 0x01020300 instead of 0x010203.
You can either accept this pull request (breaking change here if someone did rely on this macro!!) or update the commented definition.