Check for config.h before inclusion #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for HAVE_CONFIG_H before inclusion. Not doing this results in having the system-wide installed library requiring config.h to be included even though it isn't shipped together (and thus failing to compile every program that depends on modbus.h and is outside its source tree).
|
It would be even better if we could remove the include of config.h, I haven't seen the problem until now because my projects (which use libmodbus) have a config.h in the root path and modbus.h uses the config.h of the application. |
|
Thank you. |
GerHobbelt
pushed a commit
to GerHobbelt/libmodbus
that referenced
this pull request
Jun 21, 2024
XRT-2963 branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing so results in modbus.h not being includable into sources outside the libmodbus source tree