-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi chain for the rest of the hmc nuts samplers #3212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for doing this! CmdStan can get a lot cleaner for most cases.
As an aside: how difficult would it be to allow the num_chains argument for the fixed_param sampler? Since we currently sometimes select it by default (stan-dev/cmdstan#1029) it's an annoying edge case for num_chains
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Issue #3204
This adds multi chain service functions for hmc nuts for adapatation and nonadaption for the unit e, diag, and dense metrics.
Intended Effect
Allow users of the service layer to use tbb multithreading to spin up multiple chains via the service layer
How to Verify
Tests added to show usage
Side Effects
Documentation
New docs added for each function
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: